D15182: ensure "make install" on windows also installs development header files

[Martin Koller]

mkoller created this revision.
mkoller added a reviewer: Marble.
Herald added projects: Marble, KDE Edu.
Herald added subscribers: kde-edu, marble-devel.
mkoller requested review of this revision.

REVISION SUMMARY
The attached change ensures we also get the header files installed.
At least this is what is needed to use the resulting install dir to build a widget using the Marble widget.

REPOSITORY
R34 Marble

REVISION DETAIL
https://phabricator.kde.org/D15182

AFFECTED FILES
lib/marble/CMakeLists.txt

To: mkoller, #marble
Cc: marble-devel, kde-edu, torhamzed, jalvarez, mnafees, shentey, chaz6, dkolozsvari, narvaez, cmihalache, rahn, apol, nienhueser

[Torsten Rahn]

rahn added a comment.


Looks good to me!

REPOSITORY
R34 Marble

REVISION DETAIL
https://phabricator.kde.org/D15182

To: mkoller, #marble
Cc: rahn, marble-devel, kde-edu, torhamzed, jalvarez, mnafees, shentey, chaz6, dkolozsvari, narvaez, cmihalache, apol, nienhueser

[Torsten Rahn]

rahn added a comment.


Have you tested creating a new deployable Windows package? Or did you just test whether compilation on the platform works? :-)

REPOSITORY
R34 Marble

REVISION DETAIL
https://phabricator.kde.org/D15182

To: mkoller, #marble
Cc: rahn, marble-devel, kde-edu, torhamzed, jalvarez, mnafees, shentey, chaz6, dkolozsvari, narvaez, cmihalache, apol, nienhueser

[Martin Koller]

Post by Torsten Rahn
rahn added a comment.
Have you tested creating a new deployable Windows package?

no

Post by Torsten Rahn
Or did you just test whether compilation on the platform works? :-)

We are using Marble in our product, and therefore we just package what was installed into a tar file,
which will then later on be extracted into the developers build-tree.
All I tested was if what was installed was enough to create a widget derived from MarbleWidget.

Post by Torsten Rahn
REPOSITORY
R34 Marble
REVISION DETAIL
https://phabricator.kde.org/D15182
To: mkoller, #marble
Cc: rahn, marble-devel, kde-edu, torhamzed, jalvarez, mnafees, shentey, chaz6, dkolozsvari, narvaez, cmihalache, apol, nienhueser

--
Best regards/Schöne Grüße

Martin
A: Because it breaks the logical sequence of discussion
Q: Why is top posting bad?

() ascii ribbon campaign - against html e-mail
/\ - against proprietary attachments

Geschenkideen, Accessoires, Seifen, Kulinarisches: www.lillehus.at

[Martin Koller]

mkoller added a comment.

Post by Torsten Rahn
Have you tested creating a new deployable Windows package?

no

Post by Torsten Rahn
Or did you just test whether compilation on the platform works? :-)

We are using Marble in our product, and therefore we just package what was installed into a tar file,
which will then later on be extracted into the developers build-tree.
All I tested was if what was installed was enough to create a widget derived from MarbleWidget.

REPOSITORY
R34 Marble

REVISION DETAIL
https://phabricator.kde.org/D15182

To: mkoller, #marble
Cc: rahn, marble-devel, kde-edu, torhamzed, jalvarez, mnafees, shentey, chaz6, dkolozsvari, narvaez, cmihalache, apol, nienhueser

[Martin Koller]

This revision was not accepted when it landed; it landed in state "Needs Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R34:d0c59d84a433: ensure "make install" on windows also installs development header files (authored by mkoller).

CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D15182?vs=40753&id=41263#toc

REPOSITORY
R34 Marble

CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D15182?vs=40753&id=41263

REVISION DETAIL
https://phabricator.kde.org/D15182

AFFECTED FILES
src/lib/marble/CMakeLists.txt

To: mkoller, #marble
Cc: rahn, marble-devel, kde-edu, torhamzed, jalvarez, mnafees, shentey, chaz6, dkolozsvari, narvaez, cmihalache, apol, nienhueser