D16866: Include a comment to the desktop file

[Aleix Pol Gonzalez]

apol created this revision.
apol added reviewers: Marble, kossebau.
Herald added projects: Marble, KDE Edu.
Herald added subscribers: kde-edu, marble-devel.
apol requested review of this revision.

REVISION SUMMARY
Otherwise the appstream file won't have a summary and appstream complains.

CCBUG: 400431

REPOSITORY
R34 Marble

BRANCH
Applications/18.12

REVISION DETAIL
https://phabricator.kde.org/D16866

AFFECTED FILES
src/plasma/wallpapers/worldmap/metadata.desktop

To: apol, #marble, kossebau
Cc: marble-devel, kde-edu, torhamzed, jalvarez, mnafees, shentey, chaz6, dkolozsvari, narvaez, cmihalache, rahn, apol, nienhueser

[Aleix Pol Gonzalez]

apol added a comment.


Related https://phabricator.kde.org/D16867

REPOSITORY
R34 Marble

REVISION DETAIL
https://phabricator.kde.org/D16866

To: apol, #marble, kossebau
Cc: marble-devel, kde-edu, torhamzed, jalvarez, mnafees, shentey, chaz6, dkolozsvari, narvaez, cmihalache, rahn, apol, nienhueser

[Sanjiban Bairagya]

sanjibanb accepted this revision as: sanjibanb.
This revision is now accepted and ready to land.

REPOSITORY
R34 Marble

BRANCH
Applications/18.12

REVISION DETAIL
https://phabricator.kde.org/D16866

To: apol, #marble, kossebau, sanjibanb
Cc: marble-devel, kde-edu, torhamzed, jalvarez, mnafees, shentey, chaz6, dkolozsvari, narvaez, cmihalache, rahn, apol, nienhueser

[Aleix Pol Gonzalez]

apol closed this revision.

REPOSITORY
R34 Marble

REVISION DETAIL
https://phabricator.kde.org/D16866

To: apol, #marble, kossebau, sanjibanb
Cc: marble-devel, kde-edu, torhamzed, jalvarez, mnafees, shentey, chaz6, dkolozsvari, narvaez, cmihalache, rahn, apol, nienhueser

[Rik Mills]

rikmills added a comment.


I think this is needed in 18.12 branch as well?

Without it, the latest change in kpackage master means the appstream data xml file is not getting generated, and hence a packaging error on that going missing.

REPOSITORY
R34 Marble

REVISION DETAIL
https://phabricator.kde.org/D16866

To: apol, #marble, kossebau, sanjibanb
Cc: rikmills, marble-devel, kde-edu, torhamzed, jalvarez, mnafees, shentey, chaz6, dkolozsvari, narvaez, cmihalache, rahn, apol, nienhueser

[Aleix Pol Gonzalez]

apol added subscribers: aacid, ltoscano.
apol added a comment.


I'm fine with backporting to 18.12, it would mean there will be a new string altogether.

You'll be getting a packaging error now because you were ignoring the appstream error this was producing after all.

Ideas @ltoscano or @aacid?

REPOSITORY
R34 Marble

REVISION DETAIL
https://phabricator.kde.org/D16866

To: apol, #marble, kossebau, sanjibanb
Cc: ltoscano, aacid, rikmills, marble-devel, kde-edu, torhamzed, jalvarez, mnafees, shentey, chaz6, dkolozsvari, narvaez, cmihalache, rahn, apol, nienhueser

[Albert Astals Cid]

aacid added a comment.


https://community.kde.org/Schedules/Applications/18.12_Release_Schedule says " Bugfixes needing user visible text changes need approval from kde-i18n-***@kde.org "

REPOSITORY
R34 Marble

REVISION DETAIL
https://phabricator.kde.org/D16866

To: apol, #marble, kossebau, sanjibanb
Cc: ltoscano, aacid, marble-devel, kde-edu, torhamzed, jalvarez, mnafees, shentey, chaz6, dkolozsvari, narvaez, cmihalache, rahn, apol, nienhueser

[Luigi Toscano]

ltoscano added a subscriber: kde-i18n-doc.

REPOSITORY
R34 Marble

REVISION DETAIL
https://phabricator.kde.org/D16866

To: apol, #marble, kossebau, sanjibanb
Cc: kde-i18n-doc, ltoscano, aacid, marble-devel, kde-edu, torhamzed, jalvarez, mnafees, shentey, chaz6, dkolozsvari, narvaez, cmihalache, rahn, apol, nienhueser

[Luigi Toscano]

ltoscano added a comment.


Translators, what do you think about this request for a string exception for Applications/18.12?

Developers, is there an alternative to this change, apart from reverting https://phabricator.kde.org/D16867 in Frameworks?

REPOSITORY
R34 Marble

REVISION DETAIL
https://phabricator.kde.org/D16866

To: apol, #marble, kossebau, sanjibanb
Cc: kde-i18n-doc, ltoscano, aacid, marble-devel, kde-edu, torhamzed, jalvarez, mnafees, shentey, chaz6, dkolozsvari, narvaez, cmihalache, rahn, apol, nienhueser

[Burkhard Lück]

lueck added a comment.

Post by Luigi Toscano
Translators, what do you think about this request for a string exception for Applications/18.12?

backporting to 18.12 is OK for the german team

REPOSITORY
R34 Marble

REVISION DETAIL
https://phabricator.kde.org/D16866

To: apol, #marble, kossebau, sanjibanb
Cc: lueck, kde-i18n-doc, ltoscano, aacid, marble-devel, kde-edu, torhamzed, jalvarez, mnafees, shentey, chaz6, dkolozsvari, narvaez, cmihalache, rahn, apol, nienhueser

[Yuri Chornoivan]

yurchor added a comment.

Post by Luigi Toscano
Translators, what do you think about this request for a string exception for Applications/18.12?

No objections to backporting from Ukrainian team.

REPOSITORY
R34 Marble

REVISION DETAIL
https://phabricator.kde.org/D16866

To: apol, #marble, kossebau, sanjibanb
Cc: yurchor, lueck, kde-i18n-doc, ltoscano, aacid, marble-devel, kde-edu, torhamzed, jalvarez, mnafees, shentey, chaz6, dkolozsvari, narvaez, cmihalache, rahn, apol, nienhueser

[Adrián Chaves Fernández]

adrianchavesfernandez added a comment.

Post by Luigi Toscano
Translators, what do you think about this request for a string exception for Applications/18.12?

No objection.

REPOSITORY
R34 Marble

REVISION DETAIL
https://phabricator.kde.org/D16866

To: apol, #marble, kossebau, sanjibanb
Cc: adrianchavesfernandez, yurchor, lueck, kde-i18n-doc, ltoscano, aacid, marble-devel, kde-edu, torhamzed, jalvarez, mnafees, shentey, chaz6, dkolozsvari, narvaez, cmihalache, rahn, apol, nienhueser