Discussion:
D7453: Marble Maps design revisions
Judit Bartha
2017-08-21 12:32:35 UTC
Permalink
juditbartha created this revision.
juditbartha added a project: Marble.

REVISION SUMMARY
Added Options menu as Kirigami ScrollablePage to side panel.

REPOSITORY
R34 Marble

REVISION DETAIL
https://phabricator.kde.org/D7453

AFFECTED FILES
src/apps/marble-maps/MainScreen.qml
src/apps/marble-maps/MarbleMaps.qrc
src/apps/marble-maps/Options.qml

To: juditbartha, #marble_material_maps
Cc: #marble_material_maps, tjakobi, mnafees, shentey, chaz6, dkolozsvari, cmihalache, rahn, nienhueser, marble-devel
Judit Bartha
2017-08-21 13:36:16 UTC
Permalink
juditbartha updated this revision to Diff 18486.
juditbartha added a comment.


Added Bookmarks as Kirigami ScrollablePage to side panel. Added drag icon to qrc.

REPOSITORY
R34 Marble

CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7453?vs=18485&id=18486

REVISION DETAIL
https://phabricator.kde.org/D7453

AFFECTED FILES
src/apps/marble-maps/Bookmarks.qml
src/apps/marble-maps/MainScreen.qml
src/apps/marble-maps/MarbleMaps.qrc
src/apps/marble-maps/material-icons/ic_drag_handle_black_48dp.png

To: juditbartha, #marble_material_maps
Cc: #marble_material_maps, tjakobi, mnafees, shentey, chaz6, dkolozsvari, cmihalache, rahn, nienhueser, marble-devel
Judit Bartha
2017-08-21 15:13:46 UTC
Permalink
juditbartha updated this revision to Diff 18493.
juditbartha added a comment.


Added Drag&Drop functionality to Bookmarks.

REPOSITORY
R34 Marble

CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7453?vs=18486&id=18493

REVISION DETAIL
https://phabricator.kde.org/D7453

AFFECTED FILES
src/apps/marble-maps/Bookmarks.qml

To: juditbartha, #marble_material_maps
Cc: #marble_material_maps, tjakobi, mnafees, shentey, chaz6, dkolozsvari, cmihalache, rahn, nienhueser, marble-devel
Judit Bartha
2017-08-21 16:58:15 UTC
Permalink
juditbartha updated this revision to Diff 18505.
juditbartha added a comment.


Added swipe-to-remove functionality to Bookmarks, but certain bugs persist:
Interrupting a swipe leaves the dark overlay over the unremoved bookmark element.
The dark overlay isn't vertically centered on the bookmark line and looks odd.

REPOSITORY
R34 Marble

CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7453?vs=18493&id=18505

REVISION DETAIL
https://phabricator.kde.org/D7453

AFFECTED FILES
src/apps/marble-maps/Bookmarks.qml

To: juditbartha, #marble_material_maps
Cc: #marble_material_maps, tjakobi, mnafees, shentey, chaz6, dkolozsvari, cmihalache, rahn, nienhueser, marble-devel
Judit Bartha
2017-08-21 18:15:05 UTC
Permalink
juditbartha updated this revision to Diff 18512.
juditbartha added a comment.


Added bottom menu containing context-based buttons. When app is in "place" mode the bookmark button (filled / unfilled star.svg) is blurry, even though the Image has the "smooth" attribute, and the svg itself is, of course normal. This doesn't happen with the "route" button, which is used in the same way.
F3871948: Screenshot_2017-08-21-21-13-03.png <https://phabricator.kde.org/F3871948>

REPOSITORY
R34 Marble

CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7453?vs=18505&id=18512

REVISION DETAIL
https://phabricator.kde.org/D7453

AFFECTED FILES
src/apps/marble-maps/FlatButton.qml
src/apps/marble-maps/MainScreen.qml
src/apps/marble-maps/MarbleMaps.qrc
src/apps/marble-maps/PlacemarkDialog.qml
src/apps/marble-maps/Search.qml
src/apps/marble-maps/SearchField.qml

To: juditbartha, #marble_material_maps
Cc: rahn, #marble_material_maps, tjakobi, mnafees, shentey, chaz6, dkolozsvari, cmihalache, nienhueser, marble-devel
Judit Bartha
2017-08-23 12:23:14 UTC
Permalink
juditbartha updated this revision to Diff 18593.
juditbartha added a comment.


Fixed Bookmarks swipe-removal color bug, added Kirigami OverlaySheet for "Part of # routes" menu.

REPOSITORY
R34 Marble

CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7453?vs=18512&id=18593

REVISION DETAIL
https://phabricator.kde.org/D7453

AFFECTED FILES
src/apps/marble-maps/Bookmarks.qml
src/apps/marble-maps/PlacemarkDialog.qml

To: juditbartha, #marble_material_maps
Cc: rahn, #marble_material_maps, tjakobi, mnafees, shentey, chaz6, dkolozsvari, cmihalache, nienhueser, marble-devel
Loading...