D13640: stop InertialEarthRotation when a new coordinate is set or keyboard interaction

[Martin Koller]

mkoller created this revision.
mkoller added reviewers: nienhueser, Marble.
Restricted Application added projects: Marble, KDE Edu.
Restricted Application added subscribers: kde-edu, marble-devel.
mkoller requested review of this revision.

REVISION SUMMARY
When one starts to spin the globe with the mouse (kinetic rotation) and while the kinetic rotation is still being
processed, setting a new position (e.g. via MarbleWidget::flyTo or via the keyboard, e.g. Home button, etc.)
two movements interfere: the kinetic rotation of the earth started by the input handler and the second animation via
the physics timeline done in the presenter.

This patch introduces a new method in the input handler to stop a possible pending earth rotation and
calls it on the different places needed.

TEST PLAN
manual testing via mouse and keyboard and with a secondary application which can call flyTo() programmatically

REPOSITORY
R34 Marble

REVISION DETAIL
https://phabricator.kde.org/D13640

AFFECTED FILES
lib/marble/MarbleInputHandler.cpp
lib/marble/MarbleInputHandler.h
lib/marble/MarbleWidget.cpp

To: mkoller, nienhueser, #marble
Cc: marble-devel, kde-edu, torhamzed, jalvarez, tjakobi, mnafees, shentey, chaz6, dkolozsvari, narvaez, cmihalache, rahn, apol, nienhueser

[Torsten Rahn]

rahn accepted this revision.
rahn added a comment.
This revision is now accepted and ready to land.


Good catch! Looks good to me. Could you commit?

REPOSITORY
R34 Marble

REVISION DETAIL
https://phabricator.kde.org/D13640

To: mkoller, nienhueser, #marble, rahn
Cc: rahn, marble-devel, kde-edu, torhamzed, jalvarez, tjakobi, mnafees, shentey, chaz6, dkolozsvari, narvaez, cmihalache, apol, nienhueser

[Martin Koller]

This revision was automatically updated to reflect the committed changes.
Closed by commit R34:f4ac4643827c: stop InertialEarthRotation when a new coordinate is set or keyboard interaction (authored by mkoller).

CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D13640?vs=36410&id=36473#toc

REPOSITORY
R34 Marble

CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D13640?vs=36410&id=36473

REVISION DETAIL
https://phabricator.kde.org/D13640

AFFECTED FILES
src/lib/marble/MarbleInputHandler.cpp
src/lib/marble/MarbleInputHandler.h
src/lib/marble/MarbleWidget.cpp

To: mkoller, nienhueser, #marble, rahn
Cc: rahn, marble-devel, kde-edu, torhamzed, jalvarez, tjakobi, mnafees, shentey, chaz6, dkolozsvari, narvaez, cmihalache, apol, nienhueser