D14098: Avoid "QObject::disconnect: Unexpected null parameter" error on application stop

[Martin Koller]

mkoller created this revision.
mkoller added a reviewer: Marble.
Restricted Application added projects: Marble, KDE Edu.
Restricted Application added subscribers: kde-edu, marble-devel.
mkoller requested review of this revision.

REVISION SUMMARY
When I use the MarbleWidget in my application - or even using my installed marble app (openSuse 42.3), I get:
QObject::disconnect: Unexpected null parameter
on exit.

I found this to be the Annotation plugin using a nullptr in m_marbleWidget
Since in the dtor there is already a check for this pointer being 0, I moved the disconnect there.

REPOSITORY
R34 Marble

REVISION DETAIL
https://phabricator.kde.org/D14098

AFFECTED FILES
plugins/render/annotate/AnnotatePlugin.cpp

To: mkoller, #marble
Cc: marble-devel, kde-edu, torhamzed, jalvarez, tjakobi, mnafees, shentey, chaz6, dkolozsvari, narvaez, cmihalache, rahn, apol, nienhueser

[Martin Koller]

mkoller added reviewers: sanjibanb, rahn.

REPOSITORY
R34 Marble

REVISION DETAIL
https://phabricator.kde.org/D14098

To: mkoller, #marble, sanjibanb, rahn
Cc: marble-devel, kde-edu, torhamzed, jalvarez, tjakobi, mnafees, shentey, chaz6, dkolozsvari, narvaez, cmihalache, rahn, apol, nienhueser

[Martin Koller]

mkoller added a comment.


ping

REPOSITORY
R34 Marble

REVISION DETAIL
https://phabricator.kde.org/D14098

To: mkoller, #marble, sanjibanb, rahn
Cc: marble-devel, kde-edu, torhamzed, jalvarez, mnafees, shentey, chaz6, dkolozsvari, narvaez, cmihalache, rahn, apol, nienhueser

[Sanjiban Bairagya]

sanjibanb accepted this revision as: sanjibanb.
This revision is now accepted and ready to land.

REPOSITORY
R34 Marble

REVISION DETAIL
https://phabricator.kde.org/D14098

To: mkoller, #marble, sanjibanb, rahn
Cc: marble-devel, kde-edu, torhamzed, jalvarez, mnafees, shentey, chaz6, dkolozsvari, narvaez, cmihalache, rahn, apol, nienhueser

[Martin Koller]

This revision was automatically updated to reflect the committed changes.
Closed by commit R34:06b978062fff: Avoid "QObject::disconnect: Unexpected null parameter" error on application stop (authored by mkoller).

CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D14098?vs=37699&id=40623#toc

REPOSITORY
R34 Marble

CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D14098?vs=37699&id=40623

REVISION DETAIL
https://phabricator.kde.org/D14098

AFFECTED FILES
src/plugins/render/annotate/AnnotatePlugin.cpp

To: mkoller, #marble, sanjibanb, rahn
Cc: marble-devel, kde-edu, torhamzed, jalvarez, mnafees, shentey, chaz6, dkolozsvari, narvaez, cmihalache, rahn, apol, nienhueser