[Differential] [Request, 10 lines] D2862: Current settings should be saved on killing app too (not only on closing app)

Discussion:

sanjibanb (Sanjiban Bairagya)

2016-09-26 20:44:03 UTC

sanjibanb created this revision.
sanjibanb added reviewers: nienhueser, rahn, kossebau.
sanjibanb added a subscriber: Marble.
sanjibanb set the repository for this revision to rMARBLE Marble.
sanjibanb added a project: Marble.

REPOSITORY
rMARBLE Marble

REVISION DETAIL
https://phabricator.kde.org/D2862

AFFECTED FILES
src/apps/marble-maps/MainScreen.qml

EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/

To: sanjibanb, nienhueser, rahn, kossebau
Cc: #marble, shentey, chaz6, dkolozsvari, cmihalache, rahn, nienhueser, marble-devel

sanjibanb (Sanjiban Bairagya)

2016-09-26 20:55:02 UTC

Permalink

sanjibanb updated this revision to Diff 6934.
sanjibanb added a comment.

Add braces

REPOSITORY
rMARBLE Marble

CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D2862?vs=6932&id=6934

REVISION DETAIL
https://phabricator.kde.org/D2862

AFFECTED FILES
src/apps/marble-maps/MainScreen.qml

EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/

To: sanjibanb, nienhueser, rahn, kossebau
Cc: #marble, shentey, chaz6, dkolozsvari, cmihalache, rahn, nienhueser, marble-devel

Sanjiban Bairagya

2017-05-26 03:31:59 UTC

Permalink

sanjibanb updated this revision to Diff 14850.
sanjibanb added a comment.

Updating diff to latest code.

REPOSITORY
R34 Marble

CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D2862?vs=6934&id=14850

REVISION DETAIL
https://phabricator.kde.org/D2862

AFFECTED FILES
src/apps/marble-maps/MainScreen.qml

To: sanjibanb, nienhueser, rahn, kossebau
Cc: #marble, mnafees, shentey, chaz6, dkolozsvari, cmihalache, rahn, nienhueser, marble-devel

Sanjiban Bairagya

2017-06-13 20:39:50 UTC

Permalink

sanjibanb updated this revision to Diff 15439.
sanjibanb removed a reviewer: kossebau.
sanjibanb added a comment.

Makes sense. I modified the patch so that it only saves settings in suspended and inactive states, but not load them during any state change, and verified that it still resolves the issue.

REPOSITORY
R34 Marble

CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D2862?vs=14850&id=15439

REVISION DETAIL
https://phabricator.kde.org/D2862

AFFECTED FILES
src/apps/marble-maps/MainScreen.qml

To: sanjibanb, nienhueser, rahn
Cc: #marble, tjakobi, mnafees, shentey, chaz6, dkolozsvari, cmihalache, rahn, nienhueser, marble-devel