Discussion:
D14053: avoid runtime error about unknown signal when compiled without WebKit
Martin Koller
2018-07-11 17:16:51 UTC
Permalink
mkoller created this revision.
mkoller added reviewers: Marble, rahn.
Restricted Application added projects: Marble, KDE Edu.
Restricted Application added subscribers: kde-edu, marble-devel.
mkoller requested review of this revision.

REVISION SUMMARY
When compiled without WebKit, (MARBLE_NO_WEBKITWIDGETS defined), I get runtime errors about unknown signals.
This patch solves this.

REPOSITORY
R34 Marble

REVISION DETAIL
https://phabricator.kde.org/D14053

AFFECTED FILES
PopupItem.cpp

To: mkoller, #marble, rahn
Cc: marble-devel, kde-edu, torhamzed, jalvarez, tjakobi, mnafees, shentey, chaz6, dkolozsvari, narvaez, cmihalache, rahn, apol, nienhueser
Torsten Rahn
2018-07-11 17:59:54 UTC
Permalink
rahn accepted this revision.
rahn added a comment.
This revision is now accepted and ready to land.


Looks good (should we switch to the new connect syntax?).

REPOSITORY
R34 Marble

REVISION DETAIL
https://phabricator.kde.org/D14053

To: mkoller, #marble, rahn
Cc: marble-devel, kde-edu, torhamzed, jalvarez, tjakobi, mnafees, shentey, chaz6, dkolozsvari, narvaez, cmihalache, rahn, apol, nienhueser
Martin Koller
2018-07-12 06:36:28 UTC
Permalink
This revision was automatically updated to reflect the committed changes.
Closed by commit R34:c4850695c31d: avoid runtime error about unknown signal when compiled without WebKit (authored by mkoller).

CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D14053?vs=37581&id=37614#toc

REPOSITORY
R34 Marble

CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D14053?vs=37581&id=37614

REVISION DETAIL
https://phabricator.kde.org/D14053

AFFECTED FILES
src/lib/marble/PopupItem.cpp

To: mkoller, #marble, rahn
Cc: marble-devel, kde-edu, torhamzed, jalvarez, tjakobi, mnafees, shentey, chaz6, dkolozsvari, narvaez, cmihalache, rahn, apol, nienhueser
Loading...